[asterisk-dev] [Code Review] 3206: HEP: Add test for PJSIP HEP packet capture

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3206/#review10852
-----------------------------------------------------------


I think it's worth it to create an IPv6 test in addition to the IPv4 test you've created here.


/asterisk/trunk/tests/hep/hep_capture_node.py
<https://reviewboard.asterisk.org/r/3206/#comment20459>

    Provide an enum-style class that provides more descriptive names for the IP family.
    
    class IPFamily:
        v4 = 2
        v6 = 10
    
    
    then
    
    if self.ip_family = IPFamily.v4:
        do_stuff
    
    This could be reused later in HEPPacketHandler.datagram_received



/asterisk/trunk/tests/hep/hep_capture_node.py
<https://reviewboard.asterisk.org/r/3206/#comment20460>

    Provide an enum-style class for the type_ids.



/asterisk/trunk/tests/hep/hep_capture_node.py
<https://reviewboard.asterisk.org/r/3206/#comment20461>

    Another place for an enum-style class to be used.


- Mark Michelson


On Feb. 11, 2014, 12:22 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3206/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2014, 12:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds the following:
> 
> * A pluggable module that emulates a HEP capture server for verifying packets.
> * A function that can, in a rudimentary fashion, verify SIP packets. It's simplistic, but good enough to verify that Asterisk sent the server the SIP message traffic we sent to it from SIPp.
> * A test that verifies that the res_hep/res_hep_pjsip modules forward SIP message traffic to our little capture server.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/tests.yaml 4685 
>   /asterisk/trunk/tests/hep/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/sipp/echo_with_deferred_sdp.xml PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/configs/ast1/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/hep_capture_node.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140211/779ebb45/attachment.html>