[asterisk-dev] [Code Review] 3062: a systemd service

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3062/#review10846
-----------------------------------------------------------



/trunk/contrib/asterisk.service
<https://reviewboard.asterisk.org/r/3062/#comment20439>

    If -n is not used, the journal considers the line as [181B blob data] (at least with the version of systemd in Debian Wheezy).
    
    Should we default to -n? Any better alteernative?


- Tzafrir Cohen


On Feb. 10, 2014, 5:16 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3062/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 5:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Installs a systemd service file for Asterisk.
> 
> Systeemd is the new "one daemon to rule them all" for Linux: http://www.freedesktop.org/wiki/Software/systemd/
> On systems without systemd this should be just a harmless (though maybe annoying) text file.
> 
> This is aimed at replacing safe_asterisk with a more reliable main loop. It almost does that. Is still fails to handle failures, as it seems that systemd's ExecPostStop command does not get the exist status of the stopped command.
> 
> 
> Diffs
> -----
> 
>   /trunk/contrib/scripts/live_ast 407855 
>   /trunk/contrib/scripts/asterisk_cleanup PRE-CREATION 
>   /trunk/contrib/asterisk.service PRE-CREATION 
>   /trunk/Makefile 407855 
> 
> Diff: https://reviewboard.asterisk.org/r/3062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140210/243dfe54/attachment-0001.html>