[asterisk-dev] [Code Review] 3202: install_subst: helper script for installing with path substitution

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3202/#review10839
-----------------------------------------------------------


Wouldn't it be better to move the entire make-config to a separate script?
That @if is way too large for a single makefile command.


/trunk/build_tools/install_subst
<https://reviewboard.asterisk.org/r/3202/#comment20432>

    Useless trailing ';'.


- wdoekes


On Feb. 10, 2014, 12:45 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3202/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 12:45 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The Makefile repeats several time installing some scripts with paths (as denoted in __<special name>__) substituted with their actual values.
> 
> Substituting this, along with handling the errors correctly, is something that should not be repeated again and again in the makefile. This commit moves it to a single script:
> 
> ./build_tools/install_subst [-d] <src> <dst>
> 
> It installs <src> to <dst> but first substitutes some variables in it. -d (data) installs it as a data file (-m644). Otherwise it is an executable (install's default permissions).
> 
> I want this in order to avoid having yet another copy of the above for the systemd unit file (review 3062).
> 
> 
> Diffs
> -----
> 
>   /trunk/build_tools/install_subst PRE-CREATION 
>   /trunk/Makefile 407855 
> 
> Diff: https://reviewboard.asterisk.org/r/3202/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140210/94369916/attachment.html>