[asterisk-dev] [Code Review] 3200: pjsip_cli: Memory leak in ast_sip_cli_print_sorcery_objectset

[George Joseph]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3200/
-----------------------------------------------------------

(Updated Feb. 7, 2014, 3:18 p.m.)


Review request for Asterisk Developers.


Changes
-------

use ast_alloca, remove failure detect, changed to declare top instead of calloc.


Bugs: ASTERISK-23266
    https://issues.asterisk.org/jira/browse/ASTERISK-23266


Repository: Asterisk


Description
-------

I left out 2 ast_variables_destroy() calls so the variables allocated by ast_sorcery_objectset_create() never get released.

It leaks whenever someone does a 
pjsip show <object_type> <object_id>
from the command line.

Added the 2 calls before the error and success returns.


Diffs (updated)
-----

  branches/12/res/res_pjsip/pjsip_cli.c 407750 
  branches/12/main/config.c 407750 

Diff: https://reviewboard.asterisk.org/r/3200/diff/


Testing
-------


Thanks,

George Joseph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140207/8b885f97/attachment.html>