[asterisk-dev] [Code Review] 3183: ARI: pass channel variables into originate as opposed to assigning after originate

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3183/#review10806
-----------------------------------------------------------



/branches/12/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/3183/#comment20358>

    This should log an error not warning.  The message seems to indicate that there was something wrong with the input, while we actually had a memory allocation failure.  Might also be useful for this to mention that Originate is being aborted.



/branches/12/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/3183/#comment20361>

    Why not ast_ari_response_alloc_failed?


- Corey Farrell


On Feb. 6, 2014, 2:57 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3183/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 2:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch tweaks the behaviour of POST /channels with channel variables such that the variables are passed into the pbx.c routines that perform the origination. This allows the variables to be assigned to the newly created channels immediately upon their construction, as opposed to be assigned after the originate has completed.
> 
> The upshot of this is that the variables are available on the channels if they execute in the dialplan, as opposed to only being available once the channels are answered.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/ari/resource_channels.c 407562 
> 
> Diff: https://reviewboard.asterisk.org/r/3183/diff/
> 
> 
> Testing
> -------
> 
> Both testsuite originate tests still pass.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140206/6b9f8971/attachment.html>