[asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint <endpoint> shows allow/disallow codecs the same - OPTION 1

[Joshua Colp]

> On Feb. 6, 2014, 3:52 p.m., Joshua Colp wrote:
> > While this works I'm not happy with pushing this down to such a low level. What if in the future I want to filter something else?
> > 
> > What I'd really like to see is something on top which allows you to arbitrarily filter anything. If something similar came up in the future then we'd have an immediate easy solution with no core changes and it would also allow the information to still exist for cases where you do want to get it.
> 
> Scott Griepentrog wrote:
>     The other option would be to add another parameter to the ast_sorcery_object_field_register() which would indicate a "hidden" option.  I can write that up as a separate review and see which one is preferred.  Which is now up for review: https://reviewboard.asterisk.org/r/3193/
>
> 
> Joshua Colp wrote:
>     I disagree that that is the only other option. You don't have to consume the information provided from sorcery as-is, and you don't have to push filtering down to that level. Something that sits between sorcery and the consumer can easily do the filtering based on information the consumer provides.

To go a step further: Whether an object field should be hidden is not a property of the object field itself, it is a constraint within the consumer.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3136/#review10786
-----------------------------------------------------------


On Feb. 6, 2014, 5:40 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3136/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 5:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23092
>     https://issues.asterisk.org/jira/browse/ASTERISK-23092
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> WAS:
> 
> Insert a ! prefix in the display of endpoint disallow value.  Result is:
> 
>  disallow                      : !(ulaw|alaw)
> 
> NOW:
> 
> Remove the disallow option from generated lists, while still accepting it from a configuration file.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/pjsip_configuration.c 407196 
>   /branches/12/main/sorcery.c 407196 
>   /branches/12/main/config_options.c 407196 
>   /branches/12/include/asterisk/config_options.h 407196 
> 
> Diff: https://reviewboard.asterisk.org/r/3136/diff/
> 
> 
> Testing
> -------
> 
> Ran command and checked output.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140206/74acd68d/attachment.html>