[asterisk-dev] [Code Review] 3186: AMI Security Events: document the events; add optional IEs to the events

[Leif Madsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3186/#review10783
-----------------------------------------------------------

Ship it!


Other than the s/, security/, 'security'/ in the CHANGES file, this looks good to me!

- Leif Madsen


On Feb. 5, 2014, 10:51 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3186/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 10:51 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch:
> (1) Adds optional IEs to the AMI events. The optional fields are documented as not being required.
> (2) Adds documentation for all of the Security Events.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/security_events.c 407401 
>   /branches/12/UPGRADE.txt 407402 
>   /branches/12/CHANGES 407402 
> 
> Diff: https://reviewboard.asterisk.org/r/3186/diff/
> 
> 
> Testing
> -------
> 
> Tests that use the AMI events in the testsuite continue to pass.
> 
> Tested documentation through the CLI.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140206/968d83b2/attachment-0001.html>