[asterisk-dev] [Code Review] 3183: ARI: pass channel variables into originate as opposed to assigning after originate

[Matt Jordan]

> On Feb. 6, 2014, 6:58 a.m., Joshua Colp wrote:
> > /branches/12/res/ari/resource_channels.c, lines 704-705
> > <https://reviewboard.asterisk.org/r/3183/diff/1/?file=53437#file53437line704>
> >
> >     Should this actually just completely fail this? Otherwise you get a list which doesn't contain all of your JSON variables. Which, if you experienced it would cause you to scratch your head and spend time wondering what is going on.

Works for me. Fixed.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3183/#review10774
-----------------------------------------------------------


On Feb. 5, 2014, 10:41 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3183/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 10:41 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch tweaks the behaviour of POST /channels with channel variables such that the variables are passed into the pbx.c routines that perform the origination. This allows the variables to be assigned to the newly created channels immediately upon their construction, as opposed to be assigned after the originate has completed.
> 
> The upshot of this is that the variables are available on the channels if they execute in the dialplan, as opposed to only being available once the channels are answered.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/ari/resource_channels.c 407401 
> 
> Diff: https://reviewboard.asterisk.org/r/3183/diff/
> 
> 
> Testing
> -------
> 
> Both testsuite originate tests still pass.
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140206/166f7796/attachment.html>