[asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

[opticron]

> On April 29, 2014, 7:28 a.m., Joshua Colp wrote:
> > branches/11/res/res_http_websocket.c, line 125
> > <https://reviewboard.asterisk.org/r/3481/diff/2/?file=58003#file58003line125>
> >
> >     Is there any need for this since it should always be non-NULL now?

There is at least one code path where this can still occur on session creation.


> On April 29, 2014, 7:28 a.m., Joshua Colp wrote:
> > branches/11/res/res_http_websocket.c, line 195
> > <https://reviewboard.asterisk.org/r/3481/diff/2/?file=58003#file58003line195>
> >
> >     I don't see a close_sent change in here.

close_sent is set to 1 on line 206.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3481/#review11778
-----------------------------------------------------------


On April 28, 2014, 1:18 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3481/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 1:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23605
>     https://issues.asterisk.org/jira/browse/ASTERISK-23605
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This resolves a race condition where data could be written to a NULL FILE pointer causing a crash as a websocket connection was in the process of shutting down by adding locking to accesses and modifications of the websocket session struct.
> 
> 
> Diffs
> -----
> 
>   branches/11/res/res_http_websocket.c 413007 
> 
> Diff: https://reviewboard.asterisk.org/r/3481/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140429/13dfb84b/attachment.html>