[asterisk-dev] [Code Review] 3485: pjsip: Fix a bug where transferring to a parking extension causes calls to hang

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3485/
-----------------------------------------------------------

(Updated April 28, 2014, 2:10 p.m.)


Review request for Asterisk Developers, Matt Jordan and Mark Michelson.


Changes
-------

Ok, this changes the angle of approach significantly. Instead of making an exception for parking as far as the PJSIP logic goes, we forward the new_channel_cb into the parking blind transfer function and use it on whichever channel is going to get parked (either local or the one being transferred). I've now tested this on both two party bridges and multi party bridges and it seems to work without fail.


Repository: Asterisk


Description
-------

If a PJSIP endpoint attempts to blind transfer to a parking extension, there is an override to the normal transfer logic that can make things act a little weird. We noticed that this would leave various phones hanging on transfer screens without progressing. When the transfer was considered successful, PJSIP deferred the actual action of sending the 200 notify and the actual trigger for that happening never occurs when the transfer is to a parking extension.

In order to handle this, the bridge function that handles blind transfers now returns a different value if a call was parked and if the channel driver needs to react differently in this case, it can.  In the case of PJSIP, we respond to transfers to park by immediately sending the notify with 200 OK sip frag instead of deferring the action.


Diffs (updated)
-----

  /branches/12/res/parking/parking_bridge_features.c 413071 
  /branches/12/main/parking.c 413071 
  /branches/12/main/bridge.c 413071 
  /branches/12/include/asterisk/parking.h 413071 

Diff: https://reviewboard.asterisk.org/r/3485/diff/


Testing
-------

Before patch:
* Blind transfer on Polycom SPIP: Phone is on the blind transfer screen until it either manually hangs up or 60 seconds pass and Asterisk terminates the session.

After the patch:
* Blind transfer on Polycom SPIP: Phone immediately leaves the blind transfer screen and goes back to idle mode.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140428/bf7b2d25/attachment.html>