[asterisk-dev] [Code Review] 3481: Websocket: Add locking around session access and modification

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3481/
-----------------------------------------------------------

(Updated April 28, 2014, 1:18 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address Matt's concerns and push response-close transmission to the session destructor.


Bugs: ASTERISK-23605
    https://issues.asterisk.org/jira/browse/ASTERISK-23605


Repository: Asterisk


Description
-------

This resolves a race condition where data could be written to a NULL FILE pointer causing a crash as a websocket connection was in the process of shutting down by adding locking to accesses and modifications of the websocket session struct.


Diffs (updated)
-----

  branches/11/res/res_http_websocket.c 413007 

Diff: https://reviewboard.asterisk.org/r/3481/diff/


Testing
-------


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140428/4feb5f9c/attachment-0001.html>