[asterisk-dev] [Code Review] 3428: Testsuite: ARI Playback Tones tests for channels and bridges

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3428/
-----------------------------------------------------------

(Updated April 25, 2014, 4:21 p.m.)


Review request for Asterisk Developers.


Changes
-------

* Address the findings posted by mjordan
* Eliminate the need for callbacks in the bridge play tones test where I could by doing more the way the channels test was doing things
* Add channels test for tones with tone zone specified in the URI


Bugs: ASTERISK-23433
    https://issues.asterisk.org/jira/browse/ASTERISK-23433


Repository: testsuite


Description
-------

The YAML files have pretty apt descriptions.

Channel version:
* Originate a channel
* Playback a tone
* Pause it
* Unpause it
* Restart it
* Delete the tone playback
* Delete the channel
* Validate all the events

Bridge version:
* Originate a channel
* Create a bridge
* Add the channel to the bridge
* Start a tone playback on the bridge
* Delete the tone playback
* Delete the channel
* Validate all the events


Diffs (updated)
-----

  /asterisk/trunk/tests/rest_api/channels/playback/tests.yaml 4991 
  /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/rest_api/bridges/playback/tones/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/rest_api/bridges/playback/tones/bridges_play.py PRE-CREATION 
  /asterisk/trunk/tests/rest_api/bridges/playback/tests.yaml 4991 

Diff: https://reviewboard.asterisk.org/r/3428/diff/


Testing
-------

Ran tests, varied results, the usual.  They aren't especially changed from the tests they are based on (in each case there is an existing baseline test in the same folder which handles sounds).


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140425/3e51a335/attachment.html>