[asterisk-dev] [Code Review] 3480: chan_pjsip: Implement get_pvt_uniqueid channel technology callback.

Matt Jordan reviewboard at asterisk.org
Fri Apr 25 14:05:56 CDT 2014



> On April 25, 2014, 12:02 p.m., Matt Jordan wrote:
> > /branches/12/channels/chan_pjsip.c, line 927
> > <https://reviewboard.asterisk.org/r/3480/diff/1/?file=57904#file57904line927>
> >
> >     I'm not sure about using threadstorage for this. One of the places that this gets called from is the bridging core via set_bridge_peer_vars_2party. That particular call can happen on a number of different threads, and will always involve callbacks into multiple channels on the same thread of execution.
> 
> Joshua Colp wrote:
>     The code actually strdupas the value in that case so it won't be a problem there.
>     
>     My only other options are:
>     1. Change that callback to return an allocated value
>     2. Duplicate storage of the call-id in PJSIP land and place it on the session

As long as there's not a cross-thread worry, then I don't mind the thread local storage.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3480/#review11748
-----------------------------------------------------------


On April 25, 2014, 11:43 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3480/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 11:43 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change implements the "get_pvt_uniqueid" channel technology callback in chan_pjsip which returns the call-id of the underlying dialog in use.
> 
> 
> Diffs
> -----
> 
>   /branches/12/channels/chan_pjsip.c 413007 
> 
> Diff: https://reviewboard.asterisk.org/r/3480/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140425/3fac9fda/attachment-0001.html>


More information about the asterisk-dev mailing list