[asterisk-dev] [Code Review] 1803: P-Asserted-Identity Privacy - fixed behaviour - trust peer

[jamicque]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1803/
-----------------------------------------------------------

(Updated April 25, 2014, 12:48 p.m.)


Status
------

This change has been discarded.


Review request for Asterisk Developers.


Bugs: ASTERISK-19465
    https://issues.asterisk.org/jira/browse/ASTERISK-19465


Repository: Asterisk


Description
-------

It seams that in Asterisk privacy with PAI is not implemented correctly.

According to RFC 3325 when using privacy, PAI header should be set to caller num and name. The privacy is implemented by adding privacy: id header.
Now when we use pai and callpres=prohib in P-Asserted-Identity header we have something which is not correct to any rfc.
P-Asserted-Identity: "Anonymous" <sip:anonymous at anonymous.invalid>

What my patch does:
1) adds new configurable parameter for peer - trustpeer (whether we should send privacy information to peer or not)
2) it adds Privacy header to trusted peer when PAI and CLIR is used (values "id")
3) When PAI or RPID with CLIR is used and fromuser is set it is often used for authentication/recognition of the peer on the other side so we set the proper domain (not anonymous.invalid)


Diffs
-----

  /trunk/configs/sip.conf.sample 358608 
  /trunk/channels/sip/include/sip.h 358575 
  /trunk/channels/chan_sip.c 358575 

Diff: https://reviewboard.asterisk.org/r/1803/diff/


Testing
-------

I've done some basing test with outgoing calls and everything seems to works fine.


Thanks,

jamicque

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140425/0e806613/attachment.html>