[asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3479/#review11742
-----------------------------------------------------------



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21536>

    2014



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21535>

    Are you sure you're Jonathan Rose?



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21543>

    These are always used as regular expressions. Why not just compile them here and use them as such everywhere else?



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21537>

    Since this is using PJSIP, there's no need to support previous versions of Asterisk. Just the bridging model for 12 is sufficient.



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21540>

    And just use 12 here as well



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21541>

    No spaces between parameters and their values:
    
    channel="Local/test_out at pickuptest"



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21538>

    Just use the Asterisk 12 logic



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21539>

    PEP8 Guidelines: no spaces between equals in parameters passed to a function.
    
    You may want to pass this through pylint to catch anything else as well.



/asterisk/trunk/tests/channels/pjsip/call_pickup/run-test
<https://reviewboard.asterisk.org/r/3479/#comment21542>

    Why is the Local channel shouting at me? :-)


- Matt Jordan


On April 25, 2014, 8:05 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3479/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 8:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is a modified version of the normal call pickup test which uses chan_pjsip instead of chan_sip to test call pickup functionality.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/call_pickup/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/call_pickup/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/features.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/call_pickup/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3479/diff/
> 
> 
> Testing
> -------
> 
> I tested the test by running the test.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140425/8cd3aa40/attachment-0001.html>