[asterisk-dev] [Code Review] 3420: Testsuite: Call Files' Max Retries

[Scott Emidy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3420/
-----------------------------------------------------------

(Updated April 24, 2014, 10:13 p.m.)


Review request for Asterisk Developers.


Changes
-------

Made all of the revisions opticron suggested.


Bugs: ASTERISK-23218
    https://issues.asterisk.org/jira/browse/ASTERISK-23218


Repository: testsuite


Description
-------

These tests involved checking that call files max retries are functioning as planned through four tests:

1) The first test (call_file_retries_fail) required that the call file originates a local channel to a dialplan extension that will always fail, and checks to make sure that it ran through all of its max retries.

2) The second test (call_file_retries_success) involves a call file that originates a local channel that will fail once, but then is answered before it hits its max retries.

3) The third test (call_file_retries_alwaysdelete) consists of checking whether or not the call file was deleted from the [astspooldir]'s outgoing folder when the alwaysdelete option is set to 'no'.

4) The fourth and final test (call_file_retries_archive) consists of checking whether or not the call file was placed in [astspooldir]'s outgoing_done folder when archive is set to 'yes'.


Diffs (updated)
-----

  ./asterisk/trunk/tests/pbx/tests.yaml 4983 
  ./asterisk/trunk/tests/pbx/call_file_retries_success/test-config.yaml PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_success/retries_success.py PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_success/configs/ast1/extensions.conf PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_fail/test-config.yaml PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_fail/retries_fail.py PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_fail/configs/ast1/extensions.conf PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_archive/test-config.yaml PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_archive/retries_archive.py PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_archive/configs/ast1/extensions.conf PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/test-config.yaml PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/retries_alwaysdelete.py PRE-CREATION 
  ./asterisk/trunk/tests/pbx/call_file_retries_alwaysdelete/configs/ast1/extensions.conf PRE-CREATION 
  ./asterisk/trunk/lib/python/asterisk/pluggable_modules.py 4983 

Diff: https://reviewboard.asterisk.org/r/3420/diff/


Testing
-------


Thanks,

Scott Emidy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140424/98a4c511/attachment.html>