[asterisk-dev] [Code Review] 3455: testsuite: Add chan_sip tests for sendrpid=pai/rpid tests (baseline and with trust_id_outbound)
Jonathan Rose
reviewboard at asterisk.org
Mon Apr 21 11:51:19 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3455/
-----------------------------------------------------------
(Updated April 21, 2014, 11:51 a.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers, Joshua Colp, Matt Jordan, Mark Michelson, opticron, and wdoekes.
Changes
-------
Committed in revision 4981
Bugs: AST-1301 and ASTERISK-19465
https://issues.asterisk.org/jira/browse/AST-1301
https://issues.asterisk.org/jira/browse/ASTERISK-19465
Repository: testsuite
Description
-------
Part of the effort going on with https://reviewboard.asterisk.org/r/3447/
The point of these tests is to establish requirements for developing a patch to deal with the anonymity problems described on the issues. The following charts provide the base expectations:
for sendrpid=pai:
| pres=allowed | pres=prohibited |
----------------------+-------------------------+-----------------------+
trust_id_outbound=no | PAI: 123, Privacy: none | |
----------------------+-------------------------+-----------------------+
trust_id_outbound=yes | PAI: 123, Privacy: none | PAI: 123, Privacy: id |
----------------------+-------------------------+-----------------------+
*PAI is abbreviated a bit in this chart
for sendrpid=rpid:
| pres=allowed | pres=prohibited |
----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
trust_id_outbound=no | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=off;screen=no | Remote-Party-ID: "123" <sip:123 at anonymous.invalid>party=calling;privacy=full;screen=yes |
----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
trust_id_outbound=yes | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=off;screen=no | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=full;screen=yes |
----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
Diffs
-----
/asterisk/trunk/tests/channels/SIP/tests.yaml 4958
/asterisk/trunk/tests/channels/SIP/sendrpid/tests.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/tests.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/tests.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/tests.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/rpid/tests.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/tests.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/tests.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/tests.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/sipp/send.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/sipp/receive.xml PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/configs/ast1/sip.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/SIP/sendrpid/pai/tests.yaml PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/3455/diff/
Testing
-------
Checked tests against the baseline... note that the prohib variant of the rpid=pai test fails since it is including anonymized PAI data when it should be including nothing (one of the subjects of the bug report).
The trust variants of each test require that a patch be written to add the trust_id_outbound setting described in comments on https://reviewboard.asterisk.org/r/3447/ (currently in development)
Thanks,
Jonathan Rose
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140421/14919010/attachment.html>
More information about the asterisk-dev
mailing list