[asterisk-dev] [Code Review] 3455: testsuite: Add chan_sip tests for sendrpid=pai/rpid tests (baseline and with trust_id_outbound)

Jonathan Rose reviewboard at asterisk.org
Fri Apr 18 11:32:57 CDT 2014 


> On April 18, 2014, 2:36 a.m., wdoekes wrote:
> > /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/configs/ast1/sip.conf, line 11
> > <https://reviewboard.asterisk.org/r/3455/diff/2/?file=57566#file57566line11>
> >
> >     This should be alaw obviously.

What's wrong with ulaw? It seems I'm unaware of the obvious.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3455/#review11682
-----------------------------------------------------------


On April 17, 2014, 3:07 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3455/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 3:07 p.m.)
> 
> 
> Review request for Asterisk Developers, Joshua Colp, Matt Jordan, Mark Michelson, opticron, and wdoekes.
> 
> 
> Bugs: AST-1301 and ASTERISK-19465
>     https://issues.asterisk.org/jira/browse/AST-1301
>     https://issues.asterisk.org/jira/browse/ASTERISK-19465
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Part of the effort going on with https://reviewboard.asterisk.org/r/3447/
> 
> The point of these tests is to establish requirements for developing a patch to deal with the anonymity problems described on the issues. The following charts provide the base expectations:
> 
> for sendrpid=pai:
> 
>                       | pres=allowed            | pres=prohibited       |
> ----------------------+-------------------------+-----------------------+
> trust_id_outbound=no  | PAI: 123, Privacy: none |                       |
> ----------------------+-------------------------+-----------------------+
> trust_id_outbound=yes | PAI: 123, Privacy: none | PAI: 123, Privacy: id |
> ----------------------+-------------------------+-----------------------+
> 
> *PAI is abbreviated a bit in this chart
> 
> 
> for sendrpid=rpid:
>                       | pres=allowed                                                                         | pres=prohibited                                                                         |
> ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
> trust_id_outbound=no  | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=off;screen=no | Remote-Party-ID: "123" <sip:123 at anonymous.invalid>party=calling;privacy=full;screen=yes |
> ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
> trust_id_outbound=yes | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=off;screen=no | Remote-Party-ID: "123" <sip:123 at xxx.xxx.xxx.xxx>;party=calling;privacy=full;screen=yes  |
> ----------------------+--------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------+
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 4958 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_prohib/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_yes/pres_allow/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_prohib/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_no/pres_allow/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_prohib/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/trust_legacy/pres_allow/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/rpid/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_prohib/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_yes/pres_allow/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_prohib/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_no/pres_allow/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_prohib/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/sipp/send.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/sipp/receive.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/trust_legacy/pres_allow/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sendrpid/pai/tests.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3455/diff/
> 
> 
> Testing
> -------
> 
> Checked tests against the baseline... note that the prohib variant of the rpid=pai test fails since it is including anonymized PAI data when it should be including nothing (one of the subjects of the bug report).
> 
> The trust variants of each test require that a patch be written to add the trust_id_outbound setting described in comments on https://reviewboard.asterisk.org/r/3447/ (currently in development)
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140418/44dbdb74/attachment-0001.html>

More information about the asterisk-dev mailing list