[asterisk-dev] [Code Review] 3451: app_dial and app_queue: Make lock the forwarding channel while taking the channel snapshot.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3451/
-----------------------------------------------------------

(Updated April 18, 2014, 11:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 412579


Repository: Asterisk


Description
-------

* Fixed ast_channel_publish_dial_forward() not locking the forwarded channel when taking the channel snapshot.

* Fixed app_dial.c:do_forward() using the wrong channel to get the original call forwarding string.

* Removed unnecessary locking when calling ast_channel_publish_dial() and ast_channel_publish_dial_forward() in app_dial and app_queue.  Holding channel locks when calling ast_channel_publish_dial_forward() with a forwarded channel could result in pausing the system while the stasis bus completes processsing a forwarded channel subscription.


Diffs
-----

  /branches/12/main/stasis_channels.c 412438 
  /branches/12/apps/app_queue.c 412438 
  /branches/12/apps/app_dial.c 412438 

Diff: https://reviewboard.asterisk.org/r/3451/diff/


Testing
-------

Dialed a number that redirected the call to a new number.  Call still went were expected.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140418/88116504/attachment.html>