[asterisk-dev] [Code Review] 2872: Pre-review of work to handle SRTP lifetime and MKI in a less bad way, but not the best way

[Olle E Johansson]

> On April 15, 2014, 4:24 p.m., Matt Jordan wrote:
> > I don't see a diff attached to this review. Did post-review hiccup on you? :-)

Something must have happened. Well, the patch is a secret then... It's in the lingon branch, I'll upload it when back in the office. 


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2872/#review11603
-----------------------------------------------------------


On April 11, 2014, 4:53 p.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2872/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 4:53 p.m.)
> 
> 
> Review request for Asterisk Developers and mattjordan.
> 
> 
> Bugs: ASTERISK-17899
>     https://issues.asterisk.org/jira/browse/ASTERISK-17899
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Asterisk 1.8 and later currently just refuse calls that have an SDP lifetime parameter, even if it's ridiculously high. This patch adds a treshold of 10 hours (that could be made configurable) and refuse calls with a shorter lifetime. It also parses MKI/Lifetime properly.
> 
> This is not ready for commit anywhere, but I wanted to know if we can agree that this is a good path moving forward. 
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviewboard.asterisk.org/r/2872/diff/
> 
> 
> Testing
> -------
> 
> I've sent all kind of weird SDES keys from the README.lingon and while it failed previously it now succeeds where I want to and fail when I want it to fail.
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140416/e429669c/attachment-0001.html>