[asterisk-dev] [Code Review] 3424: (mix)monitor: Add options to enable a periodic beep

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3424/#review11609
-----------------------------------------------------------

Ship it!


Looks all squared to me. Let it beep.

- Jonathan Rose


On April 14, 2014, 6:51 p.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3424/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 6:51 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add an option to enable a periodic beep to be played into a call if it
> is being recorded.  If enabled, it uses the PERIODIC_HOOK() function
> internally to play the 'beep' prompt into the call at a specified
> interval.  The option is provided for both Monitor() and MixMonitor().
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_monitor.c 412327 
>   /trunk/include/asterisk/monitor.h 412327 
>   /trunk/include/asterisk/beep.h PRE-CREATION 
>   /trunk/funcs/func_periodic_hook.c 412327 
>   /trunk/bridges/bridge_builtin_features.c 412327 
>   /trunk/apps/app_queue.c 412327 
>   /trunk/apps/app_mixmonitor.c 412327 
>   /trunk/CHANGES 412327 
> 
> Diff: https://reviewboard.asterisk.org/r/3424/diff/
> 
> 
> Testing
> -------
> 
> exten => 103,1,Answer()
>     same => n,MixMonitor(test.gsm,B(5))
>     same => n,MusicOnHold()
> 
> exten => 104,1,Answer()
>     same => n,MixMonitor(test.gsm,B)
>     same => n,MusicOnHold()
> 
> exten => 105,1,Answer()
>     same => n,MixMonitor(test.gsm,B(3))
>     same => n,StartMusicOnHold()
>     same => n,Wait(15)
>     same => n,StopMusicOnHold()
>     same => n,StopMixMonitor()
>     same => n,Wait(5)
>     same => n,Hangup()
> 
> 
> Thanks,
> 
> Russell Bryant
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140415/a6d760e3/attachment.html>