[asterisk-dev] [Code Review] 3434: libpri: Make TE-PTP mode respond to MDL TEI check requests.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3434/#review11602
-----------------------------------------------------------



/branches/1.4/q921.c
<https://reviewboard.asterisk.org/r/3434/#comment21369>

    Given that you now repeat this pattern of memset/init, you should probably just define a macro that memsets the q921_h struct and then calls Q921_INIT itself.


- Matt Jordan


On April 10, 2014, 3:28 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3434/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 3:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: PRI-165
>     https://issues.asterisk.org/jira/browse/PRI-165
> 
> 
> Repository: LibPRI
> 
> 
> Description
> -------
> 
> Some BRI devices in France insist on checking TEI's when in point-to-point mode.  If they don't get a response for TEI 0 they drop layer 1 even though libpri keeps trying to bring layer 2 up.
> 
> * Made q921_mdl_receive() handle TEI check request messages in TE-PTP mode.  Had to change q921_mdl_send()/Q921_INIT() because the PTP modes do not setup a link structure specifically for MDL as the PTMP modes do.
> 
> * Fixed q921_tei_check()/t201_expire() to check TEI's even if the network side doesn't have any assigned.  This should make TE's that request the TEI verify procedure (Q.921 Section 5.3.5) happy when the network side doesn't have any TEI's allocated.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/q921.c 2317 
> 
> Diff: https://reviewboard.asterisk.org/r/3434/diff/
> 
> 
> Testing
> -------
> 
> Setup a BRI connection where the network side is NT-PTMP mode and the CPE side is TE-PTP mode.  Also made a temporary change to cause the NT-PTMP side to initiate the TEI check request procedure on start up.
> Saw that the TE-PTP side responded with the permanently assigned TEI 0.
> Saw that the NT-PTMP side handled the unknown TEI by removing it. (TEI 0 is unknown by that side.)
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140414/3839a494/attachment.html>