[asterisk-dev] [Code Review] 3442: chan_sip: Add TELPHONECONTEXT channel variable for Request TEL URIs

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3442/#review11589
-----------------------------------------------------------

Ship it!


Thank you!

Now the question is how long we should take the Tel: URI support. Can we call to one? Can we set From: address to one?


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3442/#comment21353>

    Sadly, I think we should name this SIPURIPHONECONTEXT or something that starts with SIP like SIPDOMAIN SIPFROMADDRESS et al. Vanity tags may be a good thing.


- Olle E Johansson


On April 12, 2014, 4:35 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3442/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 4:35 a.m.)
> 
> 
> Review request for Asterisk Developers, Geert Van Pamel and Olle E Johansson.
> 
> 
> Bugs: ASTERISK-17179
>     https://issues.asterisk.org/jira/browse/ASTERISK-17179
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch is a continuation of 3349 (https://reviewboard.asterisk.org/r/3349/)
> 
> It resolves a finding oej had that the phone-context be available in a TELPHONECONTEXT channel variable. This patch adds that variable. It also allows a local number (or global number specified in the TEL URI) to be used to look up as a peer. Granted; not super useful. But hey.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/sip/include/sip.h 412292 
>   /trunk/channels/chan_sip.c 412292 
> 
> Diff: https://reviewboard.asterisk.org/r/3442/diff/
> 
> 
> Testing
> -------
> 
> See review https://reviewboard.asterisk.org/r/3441
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140412/904493bc/attachment.html>