[asterisk-dev] [Code Review] 3427: ARI: Add tones playback resource

[Jonathan Rose]

> On April 10, 2014, 9:19 a.m., Joshua Colp wrote:
> > Hrm - I'm not sure I like it being "tones". When talking about these you don't refer to them as plural. "Busy tone" for an example. Thoughts?
> 
> Matt Jordan wrote:
>     "tone" works for me.

tone will be fine. I just went by the description on the issue.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3427/#review11545
-----------------------------------------------------------


On April 8, 2014, 5:46 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3427/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 5:46 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, Joshua Colp, and Matt Jordan.
> 
> 
> Bugs: ASTERISK-23433
>     https://issues.asterisk.org/jira/browse/ASTERISK-23433
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds a tones URI type to the playback resource. The tone can be specified by name (from indications.conf) or by a tone pattern (comma separate pitch/duration list). Tones aren't like regular sounds in that they must be canceled manually before the control can move on to the next item in the queue.
> 
> Tones are capable of being paused and resumed (although they will always resumed from the beginning of the tone), restarted, and stopped.  Tones are not capable of being fastforwarded, skipped into by a duration, or rewound by a small amount. Those operations unfortunately report success rather than a lack of availability right now due to how control on playbacks is defined (a playback is either completely controllable or not). I could probably add a little more granularity to that if we want it.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_stasis_playback.c 411884 
>   /trunk/main/app.c 411884 
>   /trunk/include/asterisk/app.h 411884 
>   /trunk/CHANGES 411884 
> 
> Diff: https://reviewboard.asterisk.org/r/3427/diff/
> 
> 
> Testing
> -------
> 
> I've written two testsuite tests (one for channels, one for bridges) which queue and stop tones with playback. I'll be posting them before too long.  I've also performed all the basic control operations by hand.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140410/28976d03/attachment.html>