[asterisk-dev] [Code Review] 3426: Fix build failure on SmartOS / Illumos / SunOS

[Russell Bryant]

> On April 8, 2014, 6:31 p.m., Tzafrir Cohen wrote:
> > I know I really shouldn't be writing this, as I added one of the defined() in that line, but: shouldn't this test be done in autoconf?

Ideally, yes, but seems like a reasonable improvement that could be made later, beyond the scope of this immediate fix


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3426/#review11520
-----------------------------------------------------------


On April 8, 2014, 3:31 p.m., Sebastian Wiedenroth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3426/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 3:31 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23576
>     https://issues.asterisk.org/jira/browse/ASTERISK-23576
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> this fixes two issues when building on SmartOS:
> 
> - channels/chan_oss.c: it makes sure soundcard.h is found
> - main/Makefile: only use "-Wl,--version-script" when GNU LD is used as the Sun Linker doesn't support that. Similar checks are already used elswhere in the Makefile
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/Makefile 411655 
>   /branches/11/channels/chan_oss.c 411655 
> 
> Diff: https://reviewboard.asterisk.org/r/3426/diff/
> 
> 
> Testing
> -------
> 
> With these modifications Asterisk builds fine when using pkgsrc-2014Q1 on SmartOS
> 
> 
> Thanks,
> 
> Sebastian Wiedenroth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140409/23a2d254/attachment.html>