[asterisk-dev] [Code Review] 3415: bridging: Ensure proper locking during snapshot creation

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3415/#review11492
-----------------------------------------------------------


You need to update the doxygen in stasis_bridges.h about bridge locking preconditions for many of the functions.
ast_bridge_snapshot_create() requires the bridge locked on entry.
ast_bridge_publish_merge() requires the two bridges locked on entry.
ast_bridge_publish_blind_transfer() requires the bridge locked on entry.
ast_bridge_publish_attended_transfer_xxx() requires the involved bridges to be locked on entry.

- rmudgett


On April 3, 2014, 2:13 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3415/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 2:13 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22904
>     https://issues.asterisk.org/jira/browse/ASTERISK-22904
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While the vast majority of bridge snapshot creation is locked properly, there are currently some instances that are not. This adds the missing locking to ensure bridge state is not malleable during snapshot creation.
> 
> 
> Diffs
> -----
> 
>   branches/12/tests/test_cel.c 411576 
>   branches/12/res/ari/resource_bridges.c 411576 
>   branches/12/main/bridge_basic.c 411576 
>   branches/12/main/bridge.c 411576 
>   branches/12/apps/app_confbridge.c 411576 
> 
> Diff: https://reviewboard.asterisk.org/r/3415/diff/
> 
> 
> Testing
> -------
> 
> Ran the testsuite to ensure that it did not cause failures.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140403/d5d07c9b/attachment-0001.html>