[asterisk-dev] [Code Review] 3398: TestSuite: Fix tests affected by 411086

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3398/#review11478
-----------------------------------------------------------

Ship it!


Since we noted this behavioural correction in the UPGRADE notes for Asterisk 12.2.0, I'd say Ship It! This does correct the tests for the behaviour in Asterisk post the ref leak cleanup, which is how this should behave.

- Matt Jordan


On March 26, 2014, 8 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3398/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 8 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This fixes the two tests affected by the fix (r411086) to the bridge subscription leak. They were depending on the leaked subscription to catch bridge destruction events instead of holding an explicit subscription for that purpose. They now explicitly subscribe to and unsubscribe from the bridge at creation and destruction as necessary.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/rest_api/bridges/delete/bridge_delete.py 4885 
>   asterisk/trunk/tests/rest_api/bridges/bridge_by_id/test-config.yaml 4885 
> 
> Diff: https://reviewboard.asterisk.org/r/3398/diff/
> 
> 
> Testing
> -------
> 
> Made sure the tests got the events they were expecting.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140403/13897a55/attachment.html>