[asterisk-dev] [Code Review] 3403: Test for channel Pickup

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3403/#review11468
-----------------------------------------------------------



./asterisk/trunk/tests/apps/directed_pickup/pickup/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3403/#comment21160>

    Only one [default] is necessary.



./asterisk/trunk/tests/apps/directed_pickup/pickup/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3403/#comment21161>

    You should use Echo() here as it is not time-limited.



./asterisk/trunk/tests/apps/directed_pickup/pickup_chan/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/3403/#comment21162>

    Echo() should be used here as well.


- opticron


On March 27, 2014, 2:08 p.m., Benjamin Keith Ford wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3403/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 2:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23520
>     https://issues.asterisk.org/jira/browse/ASTERISK-23520
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This test verifies that the following scenarios work for the Pickup application:
> 
> 1. A channel starts to dial an IAX peer. While ringing, another channel picks up the first.
> 2. A channel starts to dial an IAX peer, and joins a pickup group. While ringing, another channel picks up the first from that pickup group.
> 3. A channel sets PICKUPMARK equal to a value and starts to dial an IAX peer. While ringing, another channel picks up the first using the PICKUPMARK method of the Pickup application.
> 
> 
> Diffs
> -----
> 
>   ./asterisk/trunk/tests/apps/tests.yaml 4903 
>   ./asterisk/trunk/tests/apps/directed_pickup/tests.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/apps/directed_pickup/test-config.yaml 4903 
>   ./asterisk/trunk/tests/apps/directed_pickup/run-test 4903 
>   ./asterisk/trunk/tests/apps/directed_pickup/pickup_chan/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/apps/directed_pickup/pickup_chan/run-test PRE-CREATION 
>   ./asterisk/trunk/tests/apps/directed_pickup/pickup_chan/configs/ast1/iax.conf PRE-CREATION 
>   ./asterisk/trunk/tests/apps/directed_pickup/pickup_chan/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/apps/directed_pickup/pickup/test-config.yaml PRE-CREATION 
>   ./asterisk/trunk/tests/apps/directed_pickup/pickup/configs/ast1/iax.conf PRE-CREATION 
>   ./asterisk/trunk/tests/apps/directed_pickup/pickup/configs/ast1/extensions.conf PRE-CREATION 
>   ./asterisk/trunk/tests/apps/directed_pickup/configs/ast1/iax.conf 4903 
>   ./asterisk/trunk/tests/apps/directed_pickup/configs/ast1/extensions.conf 4903 
> 
> Diff: https://reviewboard.asterisk.org/r/3403/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Keith Ford
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140401/5f131171/attachment.html>