[asterisk-dev] [Code Review] 3036: res_pjsip_transport_websocket: Fix crash with security events and improve implementation

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3036/#review10294
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Nov. 28, 2013, 9:16 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3036/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2013, 9:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22897
>     https://issues.asterisk.org/jira/browse/ASTERISK-22897
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached change fixes/tweaks a few things:
> 
> Security events now determine the transport type using a saner method (by looking at the transport type on the message itself), which includes WebSocket based connections. This means no having to create a container of configured transports and no having to iterate them.
> 
> Connection handling now uses the built-in PJSIP transport manager for figuring out what active transport/connection to use. This is based on the target IP address/port of the active WebSocket connection.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip_transport_websocket.c 403236 
>   /branches/12/res/res_pjsip/security_events.c 403236 
>   /branches/12/res/res_pjsip/pjsip_options.c 403236 
>   /branches/12/res/res_pjsip/location.c 403236 
>   /branches/12/res/res_pjsip.c 403236 
>   /branches/12/include/asterisk/res_pjsip.h 403236 
> 
> Diff: https://reviewboard.asterisk.org/r/3036/diff/
> 
> 
> Testing
> -------
> 
> Connected using JsSIP, confirmed no crash and that traffic is sent out the proper connection.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131129/35dad63d/attachment.html>