[asterisk-dev] [Code Review] 3020: Test for consistent from tag on outbound REGISTER

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3020/
-----------------------------------------------------------

(Updated Nov. 26, 2013, 11:22 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 4370


Bugs: ASTERISK-12117
    https://issues.asterisk.org/jira/browse/ASTERISK-12117


Repository: testsuite


Description
-------

This pair of tests were rewritten (from https://reviewboard.asterisk.org/r/2985/) to use SIPp instead of pcap which requires running as root.

The From header is examined by SIPp (acting as registrar) to insure that it is consistent for the duration of the test (reactor-timeout).  If it changes, SIPp aborts early to indicate a failure.


Diffs
-----

  /asterisk/trunk/tests/channels/SIP/tests.yaml 4344 
  /asterisk/trunk/tests/channels/SIP/outbound_reregister_from/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/outbound_reregister_from/sipp/register.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/outbound_reregister_from/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/outbound_register_from/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/outbound_register_from/sipp/register.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/outbound_register_from/configs/ast1/sip.conf PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/3020/diff/


Testing
-------

Ran the tests with 1.8 prior to r402604 (patch to 12117) and after.  Test properly indicates failure with unpatched code.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131126/c37003fe/attachment-0001.html>