[asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

[Joshua Colp]

> On Nov. 21, 2013, 8:05 p.m., Matt Jordan wrote:
> > /branches/12/res/res_stasis_snoop.c, lines 215-228
> > <https://reviewboard.asterisk.org/r/3003/diff/3/?file=48153#file48153line215>
> >
> >     Going out on a limb here, but if this ever occurs, something has gone horribly wrong. We should never masquerade a Snoop channel: that means someone has performed an ast_channel_yank and is now doing something godawful.
> >     
> >     It may be worthwhile having an assert in here, or something that indicates that this should not have occurred - even if we do try to 'handle it gracefully'.

It's perfectly legal for this to happen, an example would be redirecting the Snoop channel to the dialplan. It will continue to work and nothing funky will happen.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3003/#review10253
-----------------------------------------------------------


On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3003/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2013, 6:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22780
>     https://issues.asterisk.org/jira/browse/ASTERISK-22780
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds a snoop operation to channels which allows spying and whispering to occur. The operation creates a Snoop channel, sends it into a provided Stasis application, and returns a snapshot of it. Once in the Stasis application any normal operation can be done with it (such as recording or placing into a bridge).
> 
> 
> Diffs
> -----
> 
>   /branches/12/rest-api/api-docs/channels.json 402707 
>   /branches/12/res/res_stasis_snoop.exports.in PRE-CREATION 
>   /branches/12/res/res_stasis_snoop.c PRE-CREATION 
>   /branches/12/res/res_ari_channels.c 402707 
>   /branches/12/res/ari/resource_channels.c 402707 
>   /branches/12/res/ari/resource_channels.h 402707 
>   /branches/12/main/audiohook.c 402707 
>   /branches/12/include/asterisk/stasis_app_snoop.h PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3003/diff/
> 
> 
> Testing
> -------
> 
> Used my softphone to call in and then swagger-ui to create snoop channels to do various things. Testsuite test coming soon!
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131121/0b0665d5/attachment.html>