[asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3023/#review10242
-----------------------------------------------------------


Shouldn't something like this be a channel function from which you retrieve the value, instead of specifying a variable into which the name is placed?  Seems like a significant regression in spitting things out to channel variables, instead of using dialplan functions to retrieve values when needed.

- Tilghman Lesher


On Nov. 20, 2013, 9:12 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3023/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 9:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change introduces an 'f' option for the MixMonitor() application. The argument for this option specifies a channel variable into which the application should store the filename (as in, the full path) instead of the standard MIXMONITOR_FILENAME.
> 
> The rationale for this option is that MixMonitor is structured in such a way that a single channel may have multiple simultaneous MixMonitors running at any given time. Thus, the MixMonitor application should not have any assumptions that the channel has only a single MixMonitor being run on it. Setting a single MIXMONITOR_FILENAME channel variable violates such assumptions by overwriting the value set from previous invocations of MixMonitor. By using the 'f' and 'i' options for MixMonitor, a user can easily manage multiple recordings on a single channel.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_mixmonitor.c 402883 
> 
> Diff: https://reviewboard.asterisk.org/r/3023/diff/
> 
> 
> Testing
> -------
> 
> See https://reviewboard.asterisk.org/r/3024/
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131121/e46d6339/attachment.html>