[asterisk-dev] [Code Review] 3016: app_directory: Set DIRECTORY_RESULT variable to indicate why Directory application finished

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3016/
-----------------------------------------------------------

(Updated Nov. 20, 2013, 9:12 p.m.)


Review request for Asterisk Developers, Mark Michelson and rmudgett.


Changes
-------

Address Mark's review feedback, keeping FAILED since precedent favors FAILED to ERROR.


Repository: Asterisk


Description
-------

Directory is a bit of a mess stylistically... so I tried to manage this as best as I could. The premise is simple enough. Directory should set a reason for exit when it is finished. The reasons include:

     OPERATOR    user requested operator by pressing '0' for operator
     ASSISTANT   user requested assistant by pressing '*' for assistant
     TIMEOUT     user pressed nothing and Directory stopped waiting
     HANGUP      user's channel hung up
     SELECTED    user selected a user from the directory and is routed
     USEREXIT    user pressed '#' from the selection prompt to exit
     FAILED      directory failed in a way that wasn't accounted for.


Diffs (updated)
-----

  /trunk/apps/app_directory.c 402851 
  /trunk/CHANGES 402851 

Diff: https://reviewboard.asterisk.org/r/3016/diff/


Testing
-------

I tested that each of the values would be received from their respective actions with the exception of FAILED... which I put in there to account for exit conditions that I wasn't aware of anyway.

I'm currently writing a testsuite test to verify the behavior of this feature.


Thanks,

Jonathan Rose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131120/07131cac/attachment.html>