[asterisk-dev] [Code Review] 3022: res_pjsip: Respect outbound proxy in more places

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3022/#review10221
-----------------------------------------------------------


The result of this patch is that an outbound_proxy may be set on an endpoint and on an AOR. The endpoint setting is used for everything except for OPTIONS requests, which use the AOR setting.

Hm, I'm going through alternatives that don't come across as esoteric, but it's difficult to come up with anything really solid. Unfortunately, I set a precedent for this sort of thing by having "mailboxes" options that can be on endpoints and on AORs.


/branches/12/res/res_pjsip/pjsip_options.c
<https://reviewboard.asterisk.org/r/3022/#comment19558>

    This block is nearly identical to the block that adds the route header in create_out_of_dialog_request() in res_pjsip.c.
    
    I think this should be factored into its own function. This way, if there's an issue, we only have to fix it in one place. I would suggest also removing the similar code from outbound registration, but unfortunately there's a registration-specific function you call in order to change the route set.


- Mark Michelson


On Nov. 19, 2013, 10:21 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3022/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 10:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22673
>     https://issues.asterisk.org/jira/browse/ASTERISK-22673
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There are currently cases where the outbound proxy is not available to be set or is not obeyed. The attached change fixes this.
> 
> 1. An outbound proxy can now be specified on the AOR for qualify purposes if wanted.
> 2. An outbound proxy specified on the endpoint is now respected when out-of-dialog requests are created.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_pjsip/pjsip_options.c 402889 
>   /branches/12/res/res_pjsip/location.c 402889 
>   /branches/12/res/res_pjsip.c 402889 
>   /branches/12/include/asterisk/res_pjsip.h 402889 
> 
> Diff: https://reviewboard.asterisk.org/r/3022/diff/
> 
> 
> Testing
> -------
> 
> Set the option, confirmed it was used.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131120/0ff89114/attachment.html>