[asterisk-dev] [Code Review] 2988: chan_sip creates a new local tag (from-tag) for every register message

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2988/
-----------------------------------------------------------

(Updated Nov. 15, 2013, 3:31 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers, Jared Smith, Matt Jordan, Olle E Johansson, and Putnopvut.


Bugs: ASTERISK-12117
    https://issues.asterisk.org/jira/browse/ASTERISK-12117


Repository: Asterisk


Description
-------

Added field to sip_registry structure to store a local (from) tag generated at the same time as callid, and assign that tag to sip_pvt structure used to generate REGISTER requests.  This aligns code with RFC 3261 8.1.3.5 "... request constitutes a new transaction and SHOULD have the same value of the Call-ID, To, and From of the previous request...".


Diffs
-----

  /branches/1.8/channels/sip/include/sip.h 402223 
  /branches/1.8/channels/chan_sip.c 402223 

Diff: https://reviewboard.asterisk.org/r/2988/diff/


Testing
-------

Tests outbound_register_from and outbound_reregister_from added to testsuite/tests/channels/SIP and transition from Fail to Pass with this patch.


Thanks,

Scott Griepentrog

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131115/4f51e6ee/attachment-0001.html>