[asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2947/#review10199
-----------------------------------------------------------



branches/12/include/asterisk/stasis_app.h
<https://reviewboard.asterisk.org/r/2947/#comment19525>

    It should be either a channel state, or a response code. At the moment it looks like a mix of both.



branches/12/include/asterisk/stasis_app.h
<https://reviewboard.asterisk.org/r/2947/#comment19523>

    I would rather you put an _OKAY value at 0.



branches/12/include/asterisk/stasis_app.h
<https://reviewboard.asterisk.org/r/2947/#comment19521>

    blob



branches/12/res/res_stasis_answer.c
<https://reviewboard.asterisk.org/r/2947/#comment19524>

    I think you can get rid of the const and just return 0 or -1 like any other C function would.



branches/12/res/res_stasis_recording.c
<https://reviewboard.asterisk.org/r/2947/#comment19526>

    I think _set_state() would be a better name, since it's primarily setting the state, and happens to publish in the process.


- David Lee


On Nov. 15, 2013, 12:23 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2947/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 12:23 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22624
>     https://issues.asterisk.org/jira/browse/ASTERISK-22624
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added a channel recording flag that is checked before adding a channel to a bridge.  If the the channel is currently being recorded a "409 Conflict" is returned and the channel is not added to the bridge.
> 
> 
> Diffs
> -----
> 
>   branches/12/rest-api/api-docs/bridges.json 402853 
>   branches/12/res/stasis/control.c 402853 
>   branches/12/res/stasis/command.c 402853 
>   branches/12/res/stasis/command.h 402853 
>   branches/12/res/res_stasis_recording.c 402853 
>   branches/12/res/res_stasis_playback.c 402853 
>   branches/12/res/res_stasis_answer.c 402853 
>   branches/12/res/res_ari_bridges.c 402853 
>   branches/12/res/ari/resource_bridges.c 402853 
>   branches/12/include/asterisk/stasis_app_impl.h 402853 
>   branches/12/include/asterisk/stasis_app.h 402853 
> 
> Diff: https://reviewboard.asterisk.org/r/2947/diff/
> 
> 
> Testing
> -------
> 
> Ran a manual test and also wrote a testsuite test: https://reviewboard.asterisk.org/r/2951/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131115/264aa939/attachment-0001.html>