[asterisk-dev] [Code Review] 3017: PickupChan: Add ability to specify channel uniqueids as well as channel names.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3017/#review10196
-----------------------------------------------------------


Update documentation and CHANGES to reflect that channel unique IDs may be passed to PickupChan()


trunk/apps/app_directed_pickup.c
<https://reviewboard.asterisk.org/r/3017/#comment19518>

    When picking up by uniqueid, I think this should be a straight strcasecmp() and should not take length into consideration. Passing a partial uniqueid to PickupChan() doesn't make much sense.


- Mark Michelson


On Nov. 14, 2013, 9:59 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3017/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 9:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Made PickupChan() search by channel uniqueids if the search could not find a channel by name.
> 
> * Ensured PickupChan() never considers the picking channel for pickup.
> 
> * Made PickupChan() option p use a common search by name routine.  The original search was erroneously case sensitive.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_directed_pickup.c 402829 
> 
> Diff: https://reviewboard.asterisk.org/r/3017/diff/
> 
> 
> Testing
> -------
> 
> Picked up channels by name and uniqueid.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131115/320eb4c4/attachment-0001.html>