[asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2947/#review10193
-----------------------------------------------------------



branches/12/include/asterisk/stasis_app.h
<https://reviewboard.asterisk.org/r/2947/#comment19505>

    Red blob.



branches/12/include/asterisk/stasis_app.h
<https://reviewboard.asterisk.org/r/2947/#comment19507>

    This should include the meaning of non-zero return as well.



branches/12/include/asterisk/stasis_app.h
<https://reviewboard.asterisk.org/r/2947/#comment19506>

    *Unregisters



branches/12/include/asterisk/stasis_app.h
<https://reviewboard.asterisk.org/r/2947/#comment19508>

    This should include the meaning of non-zero return as well.



branches/12/include/asterisk/stasis_app_impl.h
<https://reviewboard.asterisk.org/r/2947/#comment19509>

    These two \return lines need to be reworked a bit. It would be best to remove the first one and split the second one into two lines, one each for success and error. This could also use a blank comment line between the \param block and the \return block.



branches/12/res/ari/resource_bridges.c
<https://reviewboard.asterisk.org/r/2947/#comment19515>

    I'm not sure requiring resource_bridges to have specific knowledge of possible failure modes for this action is such a good idea. It requires this section of code to be modified for every new failure mode.



branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2947/#comment19510>

    This line can go away.



branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2947/#comment19511>

    This line can go away.



branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2947/#comment19512>

    Single letter variable names are bad.



branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2947/#comment19513>

    Single letter variable names are bad.



branches/12/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2947/#comment19514>

    This should be mentioned in the doxygen block for this function.


- opticron


On Nov. 7, 2013, 5:17 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2947/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 5:17 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22624
>     https://issues.asterisk.org/jira/browse/ASTERISK-22624
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added a channel recording flag that is checked before adding a channel to a bridge.  If the the channel is currently being recorded a "409 Conflict" is returned and the channel is not added to the bridge.
> 
> 
> Diffs
> -----
> 
>   branches/12/rest-api/api-docs/bridges.json 402536 
>   branches/12/res/stasis/control.c 402536 
>   branches/12/res/stasis/command.c 402536 
>   branches/12/res/stasis/command.h 402536 
>   branches/12/res/res_stasis_recording.c 402536 
>   branches/12/res/res_stasis_playback.c 402536 
>   branches/12/res/res_stasis_answer.c 402536 
>   branches/12/res/ari/resource_bridges.c 402536 
>   branches/12/include/asterisk/stasis_app_impl.h 402536 
>   branches/12/include/asterisk/stasis_app.h 402536 
> 
> Diff: https://reviewboard.asterisk.org/r/2947/diff/
> 
> 
> Testing
> -------
> 
> Ran a manual test and also wrote a testsuite test: https://reviewboard.asterisk.org/r/2951/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131114/25b77932/attachment.html>