[asterisk-dev] [Code Review] 3009: Add channel variable that describes why a channel left a ConfBridge()

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3009/#review10190
-----------------------------------------------------------

Ship it!


This looks good and I can't think of another distinction to make among various types of kicks other than the one that already exists for endmarked kicks.

- opticron


On Nov. 13, 2013, 12:28 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3009/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2013, 12:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This introduces a channel variable called CONFBRIDGE_RESULT that can be read after an invocation of ConfBridge in order to determine why the channel left. The possible values are:
> 
> * ERROR: The channel never joined the confbridge either due to bad input to the ConfBridge, an invalid PIN, or some internal error such as a memory allocation failure.
> * HANGUP: The channel left the confbridge due to a soft or hard hangup.
> * DTMF: The channel left due to the participant pressing a DTMF sequence to leave the ConfBridge.
> * KICKED: The channel was removed from the conference either by an admin, or some outside command to kick the user from the conference.
> * ENDMARKED: The channel was removed from the conference because it had the "endmarked" option enabled and the final marked user left the conference.
> 
> If there are ideas for other useful values, please let me know.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/confbridge/conf_state_multi_marked.c 402777 
>   /trunk/apps/app_confbridge.c 402777 
> 
> Diff: https://reviewboard.asterisk.org/r/3009/diff/
> 
> 
> Testing
> -------
> 
> See review 3015
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131114/df9aed48/attachment.html>