[asterisk-dev] [Code Review] 3007: ARI: Snoop tests

Mark Michelson reviewboard at asterisk.org
Thu Nov 14 11:43:14 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3007/#review10186
-----------------------------------------------------------


Tests look good, but is there a way you could work in testing that the events for starting and stopping snooping are properly received?

- Mark Michelson


On Nov. 9, 2013, 7:20 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3007/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2013, 7:20 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22780
>     https://issues.asterisk.org/jira/browse/ASTERISK-22780
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> The attached patch adds testing for whispering and spying in ARI. It confirms that whispered or spied audio passes through the Snoop channel.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/channels/tests.yaml 4328 
>   /asterisk/trunk/tests/rest_api/channels/snoop_whisper/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/snoop_whisper/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/snoop_whisper/channel_whisper.py PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/snoop_spy/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/snoop_spy/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/channels/snoop_spy/channel_spy.py PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3007/diff/
> 
> 
> Testing
> -------
> 
> Ran tests, they passed.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131114/a6c255f3/attachment.html>


More information about the asterisk-dev mailing list