[asterisk-dev] [Code Review] 3002: pjsip: convert configuration settings names to snake case
opticron
reviewboard at asterisk.org
Thu Nov 14 10:33:23 CST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3002/#review10181
-----------------------------------------------------------
branches/12/res/res_pjsip.c
<https://reviewboard.asterisk.org/r/3002/#comment19496>
I'd go with dtls_rekey here.
In addition, you'll need to update the sample config with these new option names.
- opticron
On Nov. 8, 2013, 5:19 p.m., Kevin Harwell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3002/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 5:19 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Renamed, where appropriate, the configuration options for chan/res_pjsip to use snake case (compound words separated by an underscore). For example, faxdetect will become fax_detect, recordofffeature will become record_off_feature, etc...
>
>
> Diffs
> -----
>
> branches/12/res/res_pjsip_acl.c 402562
> branches/12/res/res_pjsip/pjsip_configuration.c 402562
> branches/12/res/res_pjsip/config_transport.c 402562
> branches/12/res/res_pjsip/config_system.c 402562
> branches/12/res/res_pjsip/config_global.c 402562
> branches/12/res/res_pjsip.c 402562
> branches/12/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py 402562
>
> Diff: https://reviewboard.asterisk.org/r/3002/diff/
>
>
> Testing
> -------
>
> Started asterisk with a basic pjsip configuration to make sure things still loaded/ran correctly.
>
>
> Thanks,
>
> Kevin Harwell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131114/919fd855/attachment.html>
More information about the asterisk-dev
mailing list