[asterisk-dev] [Code Review] 2993: testsuite: Tests for form and JSON request bodies with ARI

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2993/#review10179
-----------------------------------------------------------

Ship it!


This is good to go other than the two minor issues below.


/asterisk/team/dlee/ari-req-bodies/tests/rest_api/request-bodies/run-test
<https://reviewboard.asterisk.org/r/2993/#comment19492>

    Unused import.



/asterisk/team/dlee/ari-req-bodies/tests/rest_api/request-bodies/run-test
<https://reviewboard.asterisk.org/r/2993/#comment19491>

    Unused import.


- opticron


On Nov. 4, 2013, 3:31 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2993/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 3:31 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22685 and ASTERISK-22743
>     https://issues.asterisk.org/jira/browse/ASTERISK-22685
>     https://issues.asterisk.org/jira/browse/ASTERISK-22743
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds testsuite tests for form request bodies (content type
> application/x-www-form-urlencoded) and JSON request bodies.
> 
> Since we're testing lower level ARI functionality, this is a test
> using a simple Python script using requests to hit the API directly,
> instead of our ARI test suite abstraction.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/tests.yaml 4325 
>   /asterisk/team/dlee/ari-req-bodies/tests/rest_api/request-bodies/test-config.yaml PRE-CREATION 
>   /asterisk/team/dlee/ari-req-bodies/tests/rest_api/request-bodies/run-test PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2993/diff/
> 
> 
> Testing
> -------
> 
> The test passes.
> 
> See https://reviewboard.asterisk.org/r/2994/ and
> https://reviewboard.asterisk.org/r/2993/.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131114/7dc37c80/attachment.html>