[asterisk-dev] [Code Review] 2995: app_queue: Honor penalty limits of 0

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2995/#review10141
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Nov. 4, 2013, 10:02 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2995/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 10:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-20862
>     https://issues.asterisk.org/jira/browse/ASTERISK-20862
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In the current app_queue code from 1.8 up to trunk the upper and lower penalties can be set to 0 but the value is interpreted to be disabled instead of actually setting limits. This is especially evident if min and max limits are set to 0 and members with penalties of 0 and 1 are in the queue since the member with penalty 1 will still receive calls. This patch adjusts the special disabled value to be INT_MAX instead of 0.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/apps/app_queue.c 402335 
> 
> Diff: https://reviewboard.asterisk.org/r/2995/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of the scenario described above.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131107/1ec4746c/attachment.html>