[asterisk-dev] [Code Review] 2998: Push Security Events over AMI

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2998/
-----------------------------------------------------------

(Updated Nov. 7, 2013, 4:56 p.m.)


Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark Michelson.


Changes
-------

all review feedback so far


Repository: Asterisk


Description
-------

Adds a to AMI handler for security event messages. I'm not 100% sure if it's proper to initialize the message forwarder in a secondary initialization step like I am, but I wasn't sure if I should move the initialization of the entire security event framework to after manager initializes instead.


Diffs (updated)
-----

  /branches/12/main/security_events.c 402500 
  /branches/12/main/manager.c 402500 
  /branches/12/include/asterisk/manager.h 402500 
  /branches/12/configs/manager.conf.sample 402500 
  /branches/12/CHANGES 402500 

Diff: https://reviewboard.asterisk.org/r/2998/diff/


Testing
-------

Tested that security events get logged over AMI.  Tested that obvious memory leaks against strings and the security event system aren't occurring with MALLOC_DEBUG.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131107/0a942088/attachment.html>