[asterisk-dev] [Code Review] 2962: res_stasis.c: Fix locking issues with the app_bridge_moh container.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2962/#review10136
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Colp


On Oct. 26, 2013, 1:36 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2962/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2013, 1:36 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Fix unlinking from the app_bridges_moh container in remove_bridge_moh() without a lock under normal circumstances.
> 
> * Made check ast_bridge_set_after_callback() return value in bridge_moh_create() to handle failure.
> 
> * Fixed SCOPED_AO2LOCK() locking over too much scope in stasis_app_bridge_moh_channel() and stasis_app_bridge_moh_stop().
> 
> * Fixed unusual usage of ao2_unlink_flag() in control_unlink().
> 
> * Fixed orphaned bridge from off nominal path in stasis_app_bridge_create().
> 
> * Fixed strange construct in stasis_app_unsubscribe().  From a bad merge?
> 
> * Made load_module() cleanup on failure.
> 
> 
> Diffs
> -----
> 
>   /branches/12/res/res_stasis.c 402056 
> 
> Diff: https://reviewboard.asterisk.org/r/2962/diff/
> 
> 
> Testing
> -------
> 
> Compile and code inspection.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131107/f3b39b65/attachment.html>