[asterisk-dev] [Code Review] 2976: chan_sip: notify dialog info ignores presentation indicator in callerid

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2976/
-----------------------------------------------------------

(Updated Nov. 4, 2013, 2:15 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed review issues.  Also removed whitespace changes from diff (had editor set to auto-delete whitespace).


Bugs: AST-1175
    https://issues.asterisk.org/jira/browse/AST-1175


Repository: Asterisk


Description
-------

The presentation indicator in a callerid (e.g. set by dialplan function Set(CALLERID(name-pres)= ...)) is not checked when SIP Dialog Info Notifies are generated during extension monitoring.  Added a check to make sure the name and/or number presentations on the callee (remote identity) are set to allow.  If they are restricted then "anonymous" is used instead. 


Diffs (updated)
-----

  branches/11/channels/chan_sip.c 402448 

Diff: https://reviewboard.asterisk.org/r/2976/diff/


Testing
-------

Using SIPp subscribed to dialog-info for a phone then made a call from another phone to the subscribed phone and observed that the remote identity was being replaced when either the name and/or number presentations were set to restricted.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131104/4cf535a6/attachment.html>