[asterisk-dev] [Code Review] 2988: chan_sip creates a new local tag (from-tag) for every register message

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2988/#review10113
-----------------------------------------------------------

Ship it!


Looks good to me.

I was going to argue that: only the retry to the 401 should get the same tag and not subsequent requests. But if that properly constitutes a new transaction with the increased CSeq, we might as well reuse the tag forever like the patch does.

Note that this is not something we should mandate server side -- not that anyone planned to -- since a fair amount of proxies allow authorization (response) to be done by the proxy (without updating the CSeq), even though RFC3261-22.3 explicitly states that proxies are not allowed to do so.

- wdoekes


On Nov. 1, 2013, 9:11 p.m., Scott Griepentrog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2988/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 9:11 p.m.)
> 
> 
> Review request for Asterisk Developers, Jared Smith, Matt Jordan, Olle E Johansson, and Putnopvut.
> 
> 
> Bugs: ASTERISK-12117
>     https://issues.asterisk.org/jira/browse/ASTERISK-12117
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added field to sip_registry structure to store a local (from) tag generated at the same time as callid, and assign that tag to sip_pvt structure used to generate REGISTER requests.  This aligns code with RFC 3261 8.1.3.5 "... request constitutes a new transaction and SHOULD have the same value of the Call-ID, To, and From of the previous request...".
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/sip/include/sip.h 402223 
>   /branches/1.8/channels/chan_sip.c 402223 
> 
> Diff: https://reviewboard.asterisk.org/r/2988/diff/
> 
> 
> Testing
> -------
> 
> Tests outbound_register_from and outbound_reregister_from added to testsuite/tests/channels/SIP and transition from Fail to Pass with this patch.
> 
> 
> Thanks,
> 
> Scott Griepentrog
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131104/5d9fe27d/attachment.html>