[asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.
Matt Jordan
reviewboard at asterisk.org
Fri Nov 1 09:23:20 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2944/#review10095
-----------------------------------------------------------
branches/12/res/res_pjsip_messaging.c
<https://reviewboard.asterisk.org/r/2944/#comment19374>
I dislike casting a const char * to a char *. Preferably, this should ast_strdupa the from pointer, in case it really *does* have to be const.
- Matt Jordan
On Oct. 21, 2013, 4:41 p.m., Kevin Harwell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2944/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 4:41 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Added the ability to send messages to a URI (an associated endpoint is no longer needed).
>
>
> Diffs
> -----
>
> branches/12/res/res_pjsip_messaging.c 399639
> branches/12/res/res_pjsip.c 399639
>
> Diff: https://reviewboard.asterisk.org/r/2944/diff/
>
>
> Testing
> -------
>
> Had the PJSIP message module send a SIP message to a specified IP address.
>
>
> Thanks,
>
> Kevin Harwell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131101/8ec7e0cd/attachment.html>
More information about the asterisk-dev
mailing list