No subject

Fri Mar 15 02:20:01 CDT 2013

My only concern is really the same as Kinsey's with regards to sending double unholds. Channel technologies should be able to deal with multiple unholds just fine. What we'll need to make sure we do is to document that the unhold json publication is idempotent.

- Mark Michelson

On May 29, 2013, 10:03 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2574/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 10:03 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Mark Michelson, and Jason Parker.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * DTMF attended and blind transfers have hold/unhold behavior restored.
> 
> * External attended and blind transfers unhold the transfered party when the transfer is initiated.
> 
> * Made prohibit blind transferring a bridge marked as masquerade only.  (ConfBridge bridges)
> 
> * Made running an application or playing a file inside a bridge post the hold/unhold messages if MOH is requested.
> 
> 
> Diffs
> -----
> 
>   /trunk/bridges/bridge_builtin_features.c 390103 
>   /trunk/include/asterisk/bridging.h 390103 
>   /trunk/include/asterisk/channel.h 390103 
>   /trunk/main/bridging.c 390103 
>   /trunk/main/channel.c 390103 
> 
> Diff: https://reviewboard.asterisk.org/r/2574/diff/
> 
> 
> Testing
> -------
> 
> * Hold/unhold now works with DTMF attended and blind transfers.
> 
> * SIP attended and blind transfers stop MOH when the transfers are initiated.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

--===============4018407077069140768==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2574/">https://reviewboard.asterisk.org/r/2574/</a>
     </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">From the perspective of the hold/unhold functionality during transfers, this looks good. Ship it!

My only concern is really the same as Kinsey&#39;s with regards to sending double unholds. Channel technologies should be able to deal with multiple unholds just fine. What we&#39;ll need to make sure we do is to document that the unhold json publication is idempotent.</pre>
 <br />

<p>- Mark</p>

<br />
<p>On May 29th, 2013, 10:03 p.m. UTC, rmudgett wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers, kmoore, Mark Michelson, and Jason Parker.</div>
<div>By rmudgett.</div>

<p style="color: grey;"><i>Updated May 29, 2013, 10:03 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* DTMF attended and blind transfers have hold/unhold behavior restored.

* External attended and blind transfers unhold the transfered party when the transfer is initiated.

* Made prohibit blind transferring a bridge marked as masquerade only.  (ConfBridge bridges)

* Made running an application or playing a file inside a bridge post the hold/unhold messages if MOH is requested.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Hold/unhold now works with DTMF attended and blind transfers.

* SIP attended and blind transfers stop MOH when the transfers are initiated.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/bridges/bridge_builtin_features.c <span style="color: grey">(390103)</span></li>

 <li>/trunk/include/asterisk/bridging.h <span style="color: grey">(390103)</span></li>

 <li>/trunk/include/asterisk/channel.h <span style="color: grey">(390103)</span></li>

 <li>/trunk/main/bridging.c <span style="color: grey">(390103)</span></li>

 <li>/trunk/main/channel.c <span style="color: grey">(390103)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2574/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4018407077069140768==--