[asterisk-dev] [Code Review] 2413: Stasis http: Add configuration

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2413/
-----------------------------------------------------------

(Updated March 28, 2013, 10:17 p.m.)


Review request for Asterisk Developers and David Lee.


Changes
-------

Addressed review issues.


Bugs: ASTERISK-21267
    https://issues.asterisk.org/jira/browse/ASTERISK-21267


Repository: Asterisk


Description
-------

Added some basic configuration to stasis http.  Namely two global options:

enabled - defaults to yes and when set to no, stasis-http support is disabled.
pretty - defaults to no (compact format) otherwise when set to yes, responses from stasis-http are formatted to be human readable.


Diffs (updated)
-----

  /team/dlee/stasis-http/include/asterisk/json.h 384301 
  /team/dlee/stasis-http/main/json.c 384301 
  /team/dlee/stasis-http/res/res_stasis_http.c 384301 

Diff: https://reviewboard.asterisk.org/r/2413/diff/


Testing
-------

Ran asterisk with no options specified in the configuration file and then viewed a response to make sure it was in the appropriate format.  From there added/modified the options in the config file in various combinations and then reloaded or unloaded/loaded the module each time config file was changed and viewed stasis http responses when appropriate.  Also ran a few of the existing relevant unit tests to make sure nothing broke.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130328/d2c3ec85/attachment.htm>